fix: improve content source detection in environment switcher #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 44 44
Lines 1517 1525 +8
=======================================
+ Hits 1516 1524 +8
Misses 1 1 ☔ View full report in Codecov by Sentry. |
dylandepass
commented
May 14, 2024
rofe
reviewed
May 15, 2024
dylandepass
changed the title
Editor when in json view
rofe
requested changes
May 16, 2024
dylandepass
commented
May 16, 2024
| const mountpointUrl = new URL(mountpoint); | ||
| return mountpointUrl.host.includes('.google.com') | ||
| ? 'Google Drive' | ||
| : mountpointUrl.host.includes('.sharepoint.com') || mountpointUrl.pathname.includes('/Shared%20Documents/sites/') |
There was a problem hiding this comment.
Think we still have the problem you mentioned here by using pathname.
rofe
approved these changes
May 16, 2024
trieloff
pushed a commit
that referenced
this pull request
May 16, 2024
## [1.22.1](v1.22.0...v1.22.1) (2024-05-16) ### Bug Fixes * improve content source detection in environment switcher ([#142](#142)) ([27e0a3b](27e0a3b))
|
🎉 This PR is included in version 1.22.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment switcher tells the user which content source we will switch to when hitting the edit button. This PR makes that detection more robust and also will hide the button when it's a BYOM project.
Also allow-listed more of the files required to render the json view.