feat: support cross origin request to tools and labs #236
Conversation
| @@ -22,6 +22,7 @@ export const style = css` | |||
| pointer-events: none; | |||
| z-index: 999999999999; | |||
| font-weight: initial; | |||
| letter-spacing: initial; | |||
There was a problem hiding this comment.
Noticed that sites modifying letter-spacing also had an impact on the sidekick.
| @@ -62,7 +62,7 @@ export class Picker extends SPPicker { | |||
| } else if (!this.pointerdownState) { | |||
| // Prevent browser driven closure while opening the Picker | |||
| // and the expected event series has not completed. | |||
| this.overlayElement.manuallyKeepOpen(); | |||
| this.overlayElement?.manuallyKeepOpen(); | |||
There was a problem hiding this comment.
This starting causing some issues with one of the tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 52 52
Lines 1947 1957 +10
=========================================
+ Hits 1947 1957 +10 ☔ View full report in Codecov by Sentry. |
src/extension/auth.js
Outdated
| responseHeaders: [{ | ||
| header: 'Access-Control-Allow-Origin', | ||
| operation: 'set', | ||
| value: '*', |
There was a problem hiding this comment.
Shouldn't this be set to tools.aem.live or labs.aem.live respectively?
There was a problem hiding this comment.
How would I know which one to set though? This is set at the time of login (on their aem.page/live or host).
Think I should create two rules then?
There was a problem hiding this comment.
I think also initiatorDomains will have the same effect as being explicit with the ACAO header.
# [1.30.0](v1.29.0...v1.30.0) (2024-08-28) ### Features * support cross origin request to tools and labs ([#236](#236)) ([314e2b8](314e2b8))
Fixes: #235 and #237