feat(publish): add confirm option #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofe
commented
Sep 14, 2024
| loadPage(url) { | ||
| window.location.href = url; | ||
| if (url === window.location.href) { | ||
| window.location.reload(); |
There was a problem hiding this comment.
URLs with hashes in them aren't refreshed otherwise.
rofe
commented
Sep 14, 2024
| @@ -118,10 +118,10 @@ | |||
| * @prop {string} id The plugin ID (mandatory) | |||
| * @prop {PluginButton} [button] A button configuration object (optional) | |||
| * @prop {string} [container] The ID of a dropdown to add this plugin to (optional) | |||
| * @prop {boolean} [override] Replace an existing plugin (optional) | |||
There was a problem hiding this comment.
I decided to drop this unused legacy property. It has no more effect in the new sidekick.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-20240924 #262 +/- ##
=================================================
Coverage 99.89% 99.89%
=================================================
Files 51 51
Lines 1975 1981 +6
=================================================
+ Hits 1973 1979 +6
Misses 2 2 ☔ View full report in Codecov by Sentry. |
dylandepass
reviewed
Sep 23, 2024
dylandepass
approved these changes
Sep 23, 2024
rofe
pushed a commit
that referenced
this pull request
Sep 24, 2024
# [1.32.0](v1.31.4...v1.32.0) (2024-09-24) ### Bug Fixes * dynamically load in ui.js ([a4fc57d](a4fc57d)) * remove dynamic import from background script ([58cc888](58cc888)) ### Features * extensible source support ([#245](#245)) ([#268](#268)) ([a834be2](a834be2)) * **publish:** add confirm option ([#262](#262)) ([7e8e1fc](7e8e1fc)) * support transient site token ([#272](#272)) ([2aeb56a](2aeb56a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #260
Fix #261