Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-244 - Extensible source support (#245) #268

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

rofe
Copy link
Contributor

@rofe rofe commented Sep 20, 2024

Fix #244

(complete PR checks for #245 from @auniverseaway before merging to main)

@rofe rofe requested a review from dylandepass September 20, 2024 08:22
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (d7cc55c) to head (a2e8780).
Report is 5 commits behind head on release-20240924.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release-20240924     #268      +/-   ##
====================================================
- Coverage             99.89%   99.85%   -0.05%     
====================================================
  Files                    51       51              
  Lines                  1975     2085     +110     
====================================================
+ Hits                   1973     2082     +109     
- Misses                    2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auniverseaway
Copy link
Member

@dylandepass @rofe do you need anything else from me? Do I need to fix the -0.05% coverage somehow?

@rofe
Copy link
Contributor Author

rofe commented Sep 23, 2024

@auniverseaway I think we're good here. Diff coverage is 100%, so no worries.

@rofe rofe changed the base branch from main to release-20240924 September 24, 2024 08:50
@rofe rofe merged commit a834be2 into release-20240924 Sep 24, 2024
5 of 6 checks passed
@rofe rofe deleted the issue-244-check branch September 24, 2024 08:51
rofe pushed a commit that referenced this pull request Sep 24, 2024
# [1.32.0](v1.31.4...v1.32.0) (2024-09-24)

### Bug Fixes

* dynamically load in ui.js ([a4fc57d](a4fc57d))
* remove dynamic import from background script ([58cc888](58cc888))

### Features

* extensible source support ([#245](#245)) ([#268](#268)) ([a834be2](a834be2))
* **publish:** add confirm option ([#262](#262)) ([7e8e1fc](7e8e1fc))
* support transient site token ([#272](#272)) ([2aeb56a](2aeb56a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensible Source Support
3 participants