-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Restrict getAuthInfo Action to trusted Adobe Origins #366
Conversation
The failing tests seems unrelated to the change 🤔
Locally for me they all pass:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-20241119 #366 +/- ##
=================================================
Coverage 99.95% 99.95%
=================================================
Files 54 54
Lines 2172 2182 +10
=================================================
+ Hits 2171 2181 +10
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
🎉 This PR is included in version 7.1.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Restrict the origins for which the getAuthInfo external action will return meaningful information.
For the moment, it is just: labs.aem.live, tools.aem.live, aem.live, their edge delivery origin patterns and the development localhost.
Related Issue
Related to: #259
Motivation and Context
How Has This Been Tested?
Unit tests + installing the extension in the browser and testing with:
Screenshots (if appropriate):
Types of changes
Checklist: