Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onboarding): hardcoded aria-label on close button #376

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

rofe
Copy link
Contributor

@rofe rofe commented Nov 28, 2024

Fix #373

@rofe rofe requested a review from dylandepass November 28, 2024 14:37
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (36bf0f5) to head (0fdf4ff).

Additional details and impacted files
@@                Coverage Diff                @@
##           release-20241204     #376   +/-   ##
=================================================
  Coverage             99.95%   99.95%           
=================================================
  Files                    54       54           
  Lines                  2179     2179           
=================================================
  Hits                   2178     2178           
  Misses                    1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rofe rofe changed the base branch from main to release-20241204 December 4, 2024 09:13
@rofe rofe merged commit c65539f into release-20241204 Dec 4, 2024
6 checks passed
@rofe rofe deleted the issue-373 branch December 4, 2024 09:18
rofe pushed a commit that referenced this pull request Dec 6, 2024
## [7.1.3](v7.1.2...v7.1.3) (2024-12-06)

### Bug Fixes

* **bulk:** illegal file path handling ([#377](#377)) ([6b850c6](6b850c6))
* hardcoded icon colors ([#389](#389)) ([8a75140](8a75140))
* **onboarding:** hardcoded aria-label on close button ([#376](#376)) ([c65539f](c65539f))
* **preview:** empty error message ([#385](#385)) ([c891325](c891325))
* **sharepoint:** mp4 viewer causes 404 in status ([#371](#371)) ([f1e5d73](f1e5d73))
* **view-doc-source:** check any url ([#392](#392)) ([2bf4f7e](2bf4f7e))
@trieloff
Copy link

trieloff commented Dec 6, 2024

🎉 This PR is included in version 7.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[l10n] Unlocalized 'Close' aria-label in What's New dialog
3 participants