Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support development environment in switcher #90

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

dylandepass
Copy link
Member

Added missing dev environment in envSwitcher when running on localhost.

@dylandepass
Copy link
Member Author

Not sure if Development should show the Last mod date for preview?

Screenshot 2024-03-07 at 2 35 29 PM

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.14%. Comparing base (20ef535) to head (75ba0ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          41       41           
  Lines        1285     1292    +7     
=======================================
+ Hits         1274     1281    +7     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rofe
Copy link
Contributor

rofe commented Mar 8, 2024

Not sure if Development should show the Last mod date for preview?

Hmm, since development is not actually a content environment per se, it depends on which env is being proxied by the simulator. This info could be derived from the hlx:proxyUrl meta tag.

@dylandepass
Copy link
Member Author

Development will now show the preview last mod date.

@dylandepass dylandepass requested a review from rofe March 18, 2024 19:10
@dylandepass dylandepass merged commit 7009ea2 into main Mar 22, 2024
6 checks passed
@dylandepass dylandepass deleted the dev-env-support branch March 22, 2024 13:03
rofe pushed a commit that referenced this pull request Mar 27, 2024
* feat: support development environment in switcher

* fix: show preview last mod in dev
trieloff pushed a commit that referenced this pull request Mar 27, 2024
# [1.15.0](v1.14.0...v1.15.0) (2024-03-27)

### Features

* Custom JSON view ([#84](#84)) ([ce525c1](ce525c1))
* support development environment in switcher ([#90](#90)) ([7009ea2](7009ea2))
@trieloff
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rofe pushed a commit that referenced this pull request Mar 27, 2024
# [1.15.0](v1.14.0...v1.15.0) (2024-03-27)

### Features

* Custom JSON view ([#84](#84)) ([ce525c1](ce525c1))
* support development environment in switcher ([#90](#90)) ([7009ea2](7009ea2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants