Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proxy support (via ims lib) #59

Merged
merged 6 commits into from
Oct 6, 2021
Merged

feat: add proxy support (via ims lib) #59

merged 6 commits into from
Oct 6, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Sep 30, 2021

Dependencies

  • update adobe/aio-lib-ims to final released version

Before merge

  • update Dependencies (see above)
  • do one final next tag release
  • revert package.json version to master branch package.json version

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #59 (5d3a060) into master (4fa7ae9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          160       160           
  Branches        32        32           
=========================================
  Hits           160       160           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa7ae9...5d3a060. Read the comment docs.

@shazron shazron marked this pull request as draft September 30, 2021 09:49
@shazron shazron closed this Sep 30, 2021
@shazron shazron reopened this Sep 30, 2021
@shazron shazron marked this pull request as ready for review October 6, 2021 04:20
@shazron
Copy link
Member Author

shazron commented Oct 6, 2021

Do not merge until Dependencies section is complete and tests pass after.

Copy link

@Himavanth Himavanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron merged commit 381b4d8 into master Oct 6, 2021
@shazron shazron deleted the branch-prerelease branch October 6, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants