Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --open flag and pass it through, minor text changes #64

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Feb 3, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #64 (e36538c) into master (d7151a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          160       160           
  Branches        32        32           
=========================================
  Hits           160       160           
Impacted Files Coverage Δ
src/commands/auth/login.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7151a1...e36538c. Read the comment docs.

@purplecabbage purplecabbage merged commit c775eb8 into master Feb 3, 2022
@purplecabbage purplecabbage deleted the open-flag branch February 3, 2022 18:59
description: 'print access token only',
default: false
}),
open: flags.boolean({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@purplecabbage @shazron
I wonder if it would make sense to ask the user to open the login page in the browser before ?
Something like this:
Screen Shot 2022-02-11 at 5 12 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants