Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-2801 - code links in README point to a .ts file #213

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

shazron
Copy link
Member

@shazron shazron commented Feb 2, 2024

closes #212

How Has This Been Tested?

  1. rm -rf node_modules
  2. npm i
  3. npm test
  4. npm run prepack
  5. Inspect README.md for See code: links (should point to the .js file)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8af6b59) 100.00% compared to head (a6aaf3e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          546       546           
  Branches        82        82           
=========================================
  Hits           546       546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron changed the title fix: ACNA-2799 - code links in README point to a .ts file fix: ACNA-2801 - code links in README point to a .ts file Feb 2, 2024
@shazron shazron merged commit 3cc6100 into master Feb 6, 2024
7 checks passed
@shazron shazron deleted the story/ACNA-2799 branch February 6, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console plugin: code links in README point to a .ts file
2 participants