Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ability to limit action list by package. fixes #105 #109

Conversation

justinedelson
Copy link
Member

Description

  • Add the ability to limit the action list by package

Related Issue

#105

Motivation and Context

It's available in wsk, should be available in aio.

How Has This Been Tested?

  • Added unit test case
  • Manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@justinedelson justinedelson force-pushed the issue/add-package-filter-to-action-list branch from 1011e21 to e7005cd Compare February 6, 2020 13:29
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #109 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #109   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         1737      1741    +4     
  Branches       302       303    +1     
=========================================
+ Hits          1737      1741    +4     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac148cc...21cc0fd. Read the comment docs.

@justinedelson
Copy link
Member Author

I should note that I debated using an arg vs. a flag here. Obviously wsk uses what OCLIF would consider an arg but I personally try to avoid optional args -- I think they make things confusing.

@shazron
Copy link
Member

shazron commented Feb 7, 2020

We've been trying to do a 1:1 with the wsk client (so we can be almost a drop-in replacement), so I think having it as an optional arg would be preferable. @purplecabbage ?

@purplecabbage
Copy link
Member

I was thinking the same thing @shazron
Do you know how to do optional args in oclif @justinedelson ?

@justinedelson justinedelson force-pushed the issue/add-package-filter-to-action-list branch from e7005cd to b545ad8 Compare February 7, 2020 14:51
@justinedelson
Copy link
Member Author

@purplecabbage I do. I just don't like them :)

PR updated

@justinedelson justinedelson force-pushed the issue/add-package-filter-to-action-list branch from b545ad8 to 06ad266 Compare February 7, 2020 14:52
@purplecabbage purplecabbage merged commit 3ceba9e into adobe:master Feb 8, 2020
bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this pull request Jul 21, 2021
…e#109)

* adding ability to limit action list by package. fixes adobe#105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants