Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove filesystem mock, update @oclif/core to 2.8.12 (pinned) and add override #467

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented Jul 12, 2023

Motivation and Context

This is for #462 passing
The override is a workaround for #466

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron changed the title fix: remove filesystem mock fix: remove filesystem mock, update @oclif/core to 2.8.12 (pinned) and add override Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #467 (5abf6a9) into master (d710269) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #467   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          238       238           
  Branches        47        47           
=========================================
  Hits           238       238           
Impacted Files Coverage Δ
src/commands/discover.js 100.00% <100.00%> (ø)
src/commands/rollback.js 100.00% <100.00%> (ø)
src/commands/update.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant