Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #97

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Update README.md #97

merged 1 commit into from
Dec 19, 2019

Conversation

meryllblanchet
Copy link
Contributor

@meryllblanchet meryllblanchet commented Dec 19, 2019

Updated docs and added recommendation to use nvm to manage NodeJS installation and versions.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Added recommendation to use nvm to manage NodeJS installation and versions.
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #97   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          69     69           
  Branches       10     10           
=====================================
  Hits           69     69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d152b...c162739. Read the comment docs.

Copy link
Contributor

@duynguyen duynguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @meryllblanchet !

@duynguyen duynguyen merged commit 9543248 into master Dec 19, 2019
@duynguyen duynguyen deleted the meryllblanchet-patch-2 branch December 19, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants