Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IMS service token generation plugin #34

Open
moritzraho opened this issue Apr 30, 2020 · 8 comments
Open

Support for IMS service token generation plugin #34

moritzraho opened this issue Apr 30, 2020 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@moritzraho
Copy link
Member

curl --location --request POST 'https://ims-na1-stg1.adobelogin.com/ims/token/v1' \
--header 'Content-Type:  application/x-www-form-urlencoded' \
--form 'grant_type=authorization_code' \
--form 'client_id=<your service client Id>' \
--form 'client_secret=<your client secret>' \
--form 'scope=<scopes> \
--form 'code=<your permanent auth code>'
@moritzraho moritzraho added enhancement New feature or request help wanted Extra attention is needed labels Apr 30, 2020
@moritzraho
Copy link
Member Author

moritzraho commented Apr 30, 2020

The src/ims.js already provides async getAccessToken (authCode, clientId, clientSecret, scopes) { the idea is that the plugin would wrap this function to additionally provide context and caching mechanisms

@honstar
Copy link
Member

honstar commented Jan 26, 2021

@moritzraho @shazron : I started working on a separate plugin and have a working version running on my local machine. Can you guys let me know how to proceed in terms of logistics? Shall I raise a PR from my personal space?

@honstar
Copy link
Member

honstar commented Jan 27, 2021

@moritzraho
Copy link
Member Author

Hi @honstar, thanks, I will open a repository in git.corp and go through the open sourcing process to get it as part of the adobe org.

@moritzraho
Copy link
Member Author

moritzraho commented Jan 27, 2021

In the meantime we will look at your PR 🙂 , thank you so much !

@moritzraho
Copy link
Member Author

moritzraho commented Jan 27, 2021

Also, you can open a PR against this repository to integrate your plugin into: https://github.com/adobe/aio-lib-ims/blob/master/src/token-helper.js in the same way the jwt plugin is handled there. (we will publish the npm package later, but we will be able to test through local linking)

@honstar
Copy link
Member

honstar commented Jan 27, 2021

@moritzraho : I can do that, sure. Shall I use @adobe/aio-lib-ims-s2s already and you start testing via local linking?

@moritzraho
Copy link
Member Author

@moritzraho : I can do that, sure. Shall I use @adobe/aio-lib-ims-s2s already and you start testing via local linking?

Sure I think @adobe/aio-lib-ims-s2s is a good name maybe let's ask @meryllblanchet too for the naming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants