-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for IMS service token generation plugin #34
Comments
The |
@moritzraho @shazron : I started working on a separate plugin and have a working version running on my local machine. Can you guys let me know how to proceed in terms of logistics? Shall I raise a PR from my personal space? |
Here's a PR for review: https://github.com/honstar/aio-lib-ims-s2s/pull/1. cc: @moritzraho @shazron @meryllblanchet |
Hi @honstar, thanks, I will open a repository in git.corp and go through the open sourcing process to get it as part of the adobe org. |
In the meantime we will look at your PR 🙂 , thank you so much ! |
Also, you can open a PR against this repository to integrate your plugin into: https://github.com/adobe/aio-lib-ims/blob/master/src/token-helper.js in the same way the jwt plugin is handled there. (we will publish the npm package later, but we will be able to test through local linking) |
@moritzraho : I can do that, sure. Shall I use |
Sure I think @adobe/aio-lib-ims-s2s is a good name maybe let's ask @meryllblanchet too for the naming? |
The text was updated successfully, but these errors were encountered: