Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log forwarding errors API #87

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

buskamuza
Copy link
Contributor

@buskamuza buskamuza commented Dec 22, 2021

Add API for fetching log forwarding errors.

Description

As a user configures a custom log forwarding location (see adobe/aio-cli-plugin-runtime#247), it's necessary to surface any errors related to such configuration, if occur.

Related Issue

Depends on:

Motivation and Context

Allow users to troubleshoot problems related to log forwarding.

How Has This Been Tested?

Manual and automated tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #87 (48425ab) into master (e9b44bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1235      1244    +9     
  Branches       321       324    +3     
=========================================
+ Hits          1235      1244    +9     
Impacted Files Coverage Δ
src/LogForwarding.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b44bb...48425ab. Read the comment docs.

@purplecabbage purplecabbage merged commit 5d3e691 into adobe:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants