Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

UI > On The Sidebar : Highlight Open File #3501

Closed
gpuberos opened this issue Apr 19, 2013 · 9 comments
Closed

UI > On The Sidebar : Highlight Open File #3501

gpuberos opened this issue Apr 19, 2013 · 9 comments
Assignees

Comments

@gpuberos
Copy link

On the sidebar, highlight open file with green color. ex. index.html (see screenshot)

highlight-selected-file

@peterflynn
Copy link
Member

@gpuberos is this a bug you're seeing? Or a feature request?

If it's a request for a UI change... can you explain in more detail why the existing highlighting -- darker background, arrow indicator, and lighter text -- isn't enough to see which item is selected?

@gpuberos
Copy link
Author

@peterflynn sorry for my mistake, It's a feature request

When a file is selected a green highlighting (or another color) indicates the current open file, for improved visibility on darker background with arrow. It's not clear with the current contrast.

@ghost ghost assigned adrocknaphobia Apr 22, 2013
@njx
Copy link

njx commented Apr 22, 2013

Reviewed. Seems like an XD design decision. Assigning to @adrocknaphobia for now since Larz is not yet on the committer permissions list, but ultimately Larz should make the call as to whether we should do anything here.

(My personal opinion is that it's ok the way it is given that we don't generally have a very contrasty UI, but I can see why it might be a little hard to distinguish.)

@gpuberos
Copy link
Author

Thanks for your read. It's hard to distinguish because the contrast with light grey color and white is too light (on my laptop) but on my desktop it's ok with IPS Screen.

@ghost ghost assigned larz0 Apr 23, 2013
@adrocknaphobia
Copy link
Contributor

Assigning to @larz0, but I agree with @njx. It already had a pretty heavy treatment with the darker background color and arrow. I think changing to color might be too much.

@njx
Copy link

njx commented Apr 23, 2013

After using the project panel for awhile, I feel like the bigger problem is actually the contrast of the non-highlighted items (e.g. folders)--I'm finding them pretty hard to read on my retina display. I'd suggest we kick the brightness of the darker gray up a notch. @larz0, does that seem ok to you?

@peterflynn
Copy link
Member

This could also very easily be done as an extension. We could tag "Extension Idea" and close.

I agree with @njx on the separate issue of folder brightness, however -- folders feel a little too dim to me too (folder names are not that much less important than file names).

@larz0
Copy link
Member

larz0 commented May 4, 2013

I have the same issue with folder label contrast as well, let's tweaks that. I'm not sure if the open file label needs more highlighting since it already has a selected indicator, not ruling it out just yet.

@larz0
Copy link
Member

larz0 commented Jul 16, 2013

Closing this as the pull request got merged two months ago.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants