-
Notifications
You must be signed in to change notification settings - Fork 7.6k
UI > On The Sidebar : Highlight Open File #3501
Comments
@gpuberos is this a bug you're seeing? Or a feature request? If it's a request for a UI change... can you explain in more detail why the existing highlighting -- darker background, arrow indicator, and lighter text -- isn't enough to see which item is selected? |
@peterflynn sorry for my mistake, It's a feature request When a file is selected a green highlighting (or another color) indicates the current open file, for improved visibility on darker background with arrow. It's not clear with the current contrast. |
Reviewed. Seems like an XD design decision. Assigning to @adrocknaphobia for now since Larz is not yet on the committer permissions list, but ultimately Larz should make the call as to whether we should do anything here. (My personal opinion is that it's ok the way it is given that we don't generally have a very contrasty UI, but I can see why it might be a little hard to distinguish.) |
Thanks for your read. It's hard to distinguish because the contrast with light grey color and white is too light (on my laptop) but on my desktop it's ok with IPS Screen. |
After using the project panel for awhile, I feel like the bigger problem is actually the contrast of the non-highlighted items (e.g. folders)--I'm finding them pretty hard to read on my retina display. I'd suggest we kick the brightness of the darker gray up a notch. @larz0, does that seem ok to you? |
This could also very easily be done as an extension. We could tag "Extension Idea" and close. I agree with @njx on the separate issue of folder brightness, however -- folders feel a little too dim to me too (folder names are not that much less important than file names). |
I have the same issue with folder label contrast as well, let's tweaks that. I'm not sure if the open file label needs more highlighting since it already has a selected indicator, not ruling it out just yet. |
Closing this as the pull request got merged two months ago. |
On the sidebar, highlight open file with green color. ex. index.html (see screenshot)
The text was updated successfully, but these errors were encountered: