You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
A "node-core/node_modules" directory is somehow erroneously getting included in builds (both on mac and win). The only module in that is "ws-deploy" which is no longer used. (We've moved "ws" to a not-installed-by-npm module in the "thirdparty" directory.)
I'm not exactly sure how this is getting bundled in. There are no explicit rules (that I can find) to copy a node_modules directory as part of the packaging process. So, it's probably getting included in some "copy all subdirs" rule. My guess is that the clone of the repo on the build machine has a .gitignore for the node_modules directory so it never got cleaned up when we re-arranged things.
I hope the fix is simple: delete the node_modules directory from the clone of the brackets-shell repo on the build machines.
Assigning to @jasonsanjose for a first pass. Thanks!
The text was updated successfully, but these errors were encountered:
A "node-core/node_modules" directory is somehow erroneously getting included in builds (both on mac and win). The only module in that is "ws-deploy" which is no longer used. (We've moved "ws" to a not-installed-by-npm module in the "thirdparty" directory.)
I'm not exactly sure how this is getting bundled in. There are no explicit rules (that I can find) to copy a node_modules directory as part of the packaging process. So, it's probably getting included in some "copy all subdirs" rule. My guess is that the clone of the repo on the build machine has a .gitignore for the node_modules directory so it never got cleaned up when we re-arranged things.
I hope the fix is simple: delete the node_modules directory from the clone of the brackets-shell repo on the build machines.
Assigning to @jasonsanjose for a first pass. Thanks!
The text was updated successfully, but these errors were encountered: