DocumentManager.closeFullEditor()'s skipAutoSelect arg seems unused

[peterflynn]

This was once used by notifyPathDeleted()'s call to notifyFileDeleted() (which then passes the flag along to closeFullEditor()). But now that notifyPathDeleted() simply delegates over to FileSyncManager.syncOpenDocuments(), nothing in our codebase calls either closeFullEditor() or notifyFileDeleted() with this flag.

We should either (a) decide it's definitely unneeded and remove it to reduce complexity, or (b) decide it still is needed and then figure out how it should be worked into FileSyncManager.

I'm not clear on why it was needed originally -- possibly just for efficiency? Or maybe reducing flicker in the case that many images were closed at once?

[njx]

Low priority to @peterflynn, though Glenn thinks it's possible this was in the Save As work - @couzteau, do you know if this might be related?

[couzteau]

I will take a look after I get the build for scenario testing image preview out of the door.

[peterflynn]

Could maybe be tackled in a batch cleanup along with #513 & #1451

[le717]

@peterflynn This can closed due to Split View refactoring (and subsequent deprecation of this API).