This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Make the registry accept themes without main.js #8626
Milestone
Comments
Ouch. You're right, we need to fix that. |
Nominating for fixing in release 0.43. |
Reviewed medium priority in Extension Registry |
Not a blocker for 0.43, but should be in 1.0 |
I have a fix for this at #9434. |
@le717 We need to fix this in both Brackets and brackets-registry. |
@marcelgerber If my understand is correct, once it is fixed it, the code will be copied to brackets-registry. I spoke to @redmunds about that (sorta), and he told me to base the changes here. |
Yup, after thinking about it, it's probably better to do the Brackets changes first so that themes still work when theme authors update their extensions (removing the main.js). |
Right, the validation code lives in the brackets repo and gets shared by the registry. |
ingorichter
added
fixed but not closed
and removed
fix in progress
fixed but not closed
labels
Oct 9, 2014
Fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Theme extensions require an empty
main.js
in order to be uploaded to the registry. I think there had been talk to remove that restriction.The text was updated successfully, but these errors were encountered: