Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Make the registry accept themes without main.js #8626

Closed
mackenza opened this issue Aug 2, 2014 · 10 comments
Closed

Make the registry accept themes without main.js #8626

mackenza opened this issue Aug 2, 2014 · 10 comments

Comments

@mackenza
Copy link
Contributor

mackenza commented Aug 2, 2014

Theme extensions require an empty main.js in order to be uploaded to the registry. I think there had been talk to remove that restriction.

@dangoor
Copy link
Contributor

dangoor commented Aug 4, 2014

Ouch. You're right, we need to fix that.

@dangoor dangoor added this to the Release 0.43 milestone Aug 4, 2014
@dangoor
Copy link
Contributor

dangoor commented Aug 4, 2014

Nominating for fixing in release 0.43.

@dangoor
Copy link
Contributor

dangoor commented Aug 11, 2014

Reviewed medium priority in Extension Registry

@ingorichter ingorichter removed their assignment Aug 11, 2014
@dangoor dangoor modified the milestones: Release 0.43, Brackets 1.0 (#0.44) Aug 25, 2014
@dangoor
Copy link
Contributor

dangoor commented Aug 25, 2014

Not a blocker for 0.43, but should be in 1.0

@le717
Copy link
Contributor

le717 commented Oct 3, 2014

I have a fix for this at #9434.

@marcelgerber
Copy link
Contributor

@le717 We need to fix this in both Brackets and brackets-registry.

@le717
Copy link
Contributor

le717 commented Oct 4, 2014

@marcelgerber If my understand is correct, once it is fixed it, the code will be copied to brackets-registry. I spoke to @redmunds about that (sorta), and he told me to base the changes here.

@marcelgerber
Copy link
Contributor

Yup, after thinking about it, it's probably better to do the Brackets changes first so that themes still work when theme authors update their extensions (removing the main.js).

@dangoor
Copy link
Contributor

dangoor commented Oct 5, 2014

Right, the validation code lives in the brackets repo and gets shared by the registry.

@ingorichter
Copy link
Contributor

Fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants