This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Issue #5517 - css quick edit blank line number #5582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This is almost certainly correct (I'm assuming the original code was a minor premature optimization :)), though I think we can no longer easily get into the case where this was broken before because of the recent change to make it so that a given rule is only shown once. I bet you could still get into it if you happen to have two different CSS files that have matching rules on the same line number, though. In any case, this seems fine to merge, except that it needs to be merged with master due to conflicts. Would you mind doing that? |
Conflicts: src/editor/InlineTextEditor.js
|
Done. |
|
Thanks! Merging. |
njx
pushed a commit
that referenced
this pull request
Oct 22, 2013
Issue #5517 - css quick edit blank line number
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to the blank line number issue described by @njx in #5517