Enable merge queue #161
Closed
Enable merge queue #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
commented
Oct 5, 2023
| // which means that a merge_queue should already pass, the only reason we have been | ||
| // failing so far I believe is because we were not getting the event at all, so couldn't | ||
| // mark it as passing. On the chance I'm wrong, I'm leaving this here for now. | ||
| // but we may not even need a code change |
There was a problem hiding this comment.
Further proof we don't need any changes, we just need to enable the events like we did in the cla-bot-playground adobe/cla-bot-playground#370
This PR was merged based on the already existing cla-bot code, it would hang previous to changing the settings of the repo and branch protections.
|
Closing, nothing to do but push the buttons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work in progress.
I need a branch added to the staging cla-bot-playground repo which is protected by a merge queue. The events should already be turned on in there.
Checklist
Related Issue
Closes #157