Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should update contact information to not hard-code specific org team mention #63

Open
filmaj opened this issue Aug 21, 2019 · 3 comments
Labels
docs Related to project documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@filmaj
Copy link
Contributor

filmaj commented Aug 21, 2019

Currently the bot tells people to at-mention adobe/open-source-office for issues. However, if you install this app on an org different from github.com/adobe, you can't mention a team from another org.

So should at least update the instruction text we give users to not give them faulty instructions. Perhaps could get the bot to detect whether the PR is happening on the adobe org, and if so, leave those instructions in, otherwise, direct folks to email. Another option is on the magento org could at-mention a different team, like the community-eng team.

@filmaj filmaj added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested docs Related to project documentation labels Aug 21, 2019
@amithkk
Copy link

amithkk commented Oct 6, 2019

How about we take out the instruction text/title and make it part of the config? Then any org could custom set whatever message they want to when a CLA is to be signed?

I would like to take up this issue please

@filmaj
Copy link
Contributor Author

filmaj commented Oct 7, 2019

Hmm, how does per-organization configuration work for GitHub Apps?

@prashcr
Copy link
Contributor

prashcr commented Oct 12, 2019

Aside from choosing repositories, I don't think per-organization configuration is currently supported by GitHub Apps. All the apps I've seen are configured on a per-repo basis by reading files from the repo. I think it's a no-go to require a config file in every repo of every org that installs the app for this purpose.

I would go with @filmaj's approach of changing the message based on org. Let me know if you're still taking the issue @amithkk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to project documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants