-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for CLA bot to comment on PRs when user has not signed CLA #71
Comments
FYI @okorshenko this feature was not deemed desirable by some of the github.com/adobe project leads I surveyed so we would implement as something that just executes against github.com/magento projects. Also could you confirm that the "please sign" comment would only show up for a first-time contributor to a repo? Or for all contributors regardless of their first-time status? |
Hi @filmaj that is ok to have this feature for @magento only. Yesterday I was working with one first time contributor and it was not clear for him what to do and why it is red. Comment will help. Our community already knows that if we want some action from them, instruction will be posted immediately in the comment. Also, just FYI: I saw the cases when users signed CLA but did typo in github user name in the document so check was still red. Contributors are confused and don't understand why that happens. So we asked them check the signed document in the email and check spelling for GitHub user name. |
@okorshenko I spoke to the Adobe Sign team, there is unfortunately no way to pass parameters to the hosted online document 😞 that would save us a lot of trouble. This came up when I was working on the webhook implementation as well - if a parameter could be passed then that would save us a lot of work correlating signees of documents with GitHub accounts. |
Hmm, I am getting |
I have filed an issue with support over this. |
I have received a response from GitHub support. It was a permission issue and it is resolved. Onwards! Here is what the data payload looks like when creating a comment:
And here is for listing:
The above will be useful to put together the initial implementation. |
constraints:
The text was updated successfully, but these errors were encountered: