test(html pipe): Update integration test for newly exposed types in the meta JSON attributes #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he meta JSON attributes fix helix-pipeline#279
tripodsan
approved these changes
Jul 1, 2019
|
@tripodsan Sure, makes sense. |
ramboz
added a commit
to adobe/helix-pipeline
that referenced
this pull request
Jul 5, 2019
Include proper sections in the HTML pipeline instead of plain `<hr>` sectioning BREAKING CHANGE: - Remove `context.content.sections` and move the sections directly under `context.content.mdast` - Adjust json schemas accordingly - Move the section yaml meta info to `<node>.meta` - Move the section types to the mdast `<node>.meta.types` Is dependent on adobe/helix-cli#1037 fix #279
Codecov Report
@@ Coverage Diff @@
## master #1037 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 43 43
Lines 1788 1788
=======================================
Hits 1644 1644
Misses 144 144Continue to review full report at Codecov.
|
adobe-bot
pushed a commit
to adobe/helix-pipeline
that referenced
this pull request
Jul 5, 2019
# [4.0.0](v3.7.4...v4.0.0) (2019-07-05) ### Features * **html pipe:** Default pipeline should include <section/>s ([#379](#379)) ([27ad875](27ad875)), closes [adobe/helix-cli#1037](adobe/helix-cli#1037) [#279](#279) ### BREAKING CHANGES * **html pipe:** - Remove `context.content.sections` and move the sections directly under `context.content.mdast` - Adjust json schemas accordingly - Move the section yaml meta info to `<node>.meta` - Move the section types to the mdast `<node>.meta.types`
|
🎉 This PR is included in version 4.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the newly exposed
typesarray on themetaobject.fix adobe/helix-pipeline#279