Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate manifest.json with information of the static files #144

Closed
tripodsan opened this issue Sep 4, 2018 · 3 comments
Closed

generate manifest.json with information of the static files #144

tripodsan opened this issue Sep 4, 2018 · 3 comments
Assignees

Comments

@tripodsan
Copy link
Contributor

since the list of static files is know during deploy time, it can be included into the bundled distributor.

@tripodsan tripodsan self-assigned this Sep 4, 2018
@trieloff
Copy link
Contributor

trieloff commented Sep 4, 2018

I'd suggest we remove the bundled distributor entirely, given that we have a good way of using GitHub as the distributor.

@tripodsan
Copy link
Contributor Author

this is only a pre-step before we can merge the static-serving logic. As I mentioned somewhere else (can't remember where :-) Having the static delivery redirector (disty) bundled together with the html.js action saves us 1 action. so we still can have a disty per strain, but the config in the VLC is much easier, as we only need to handle 1 case.

@tripodsan
Copy link
Contributor Author

tripodsan commented Sep 6, 2018

Ok, let's just generate the manifest.json for now. I think it could serve as a good source of information for any static deployment mechanism. I will also include the content-hash of the files. eg:

{
  "styles.css": {
      "size": 1234,
      "hash": "..."
  },
  "favicon.ico": {
      "size": 1234,
      "hash": "..."
  }
}

@tripodsan tripodsan changed the title change bundled distributor to include a list of static files instead of matching /dist/* generate manifest.json with information of the static files Sep 6, 2018
tripodsan pushed a commit that referenced this issue Oct 18, 2018
Custom docker images with more logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants