Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy sets but does not use defaultRepo variable #891

Closed
rofe opened this issue May 15, 2019 · 2 comments
Closed

deploy sets but does not use defaultRepo variable #891

rofe opened this issue May 15, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rofe
Copy link
Contributor

rofe commented May 15, 2019

Follow these steps (loosely based on getting-started):

  1. hlx demo demo && cd demo
  2. hlx build
  3. git remote add origin <mytestprojectcode_repo_url>.git
  4. hlx deploy --dirty --add=default

The resulting helix-config.yaml will look like this:

#
# helix configuration for local development
#
version: 1

definitions:
  defaults:
    - &defaultRepo "<mytestprojectcode_repo_url>.git"

strains:
  - name: default
    code: <mytestprojectcode_repo_url>.git#master
    content: <mytestprojectcode_repo_url>.git#master
    static: <mytestprojectcode_repo_url>.git/htdocs#master
    package: (...)

I would expect it to make use of the *defaultRepo variable, since it's being defined above.

@rofe rofe added the enhancement New feature or request label May 15, 2019
@rofe
Copy link
Contributor Author

rofe commented May 15, 2019

Relates to #711

@kptdobe kptdobe added the good first issue Good for newcomers label Aug 28, 2019
@tripodsan
Copy link
Contributor

won't fix for helix 2. irrelevant for helix 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants