Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: confusing console output for local strains #892

Closed
rofe opened this issue May 15, 2019 · 4 comments
Closed

publish: confusing console output for local strains #892

rofe opened this issue May 15, 2019 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rofe
Copy link
Contributor

rofe commented May 15, 2019

If you have a local strain in the helix-config.yaml:

definitions:
  defaults:
    - & defaultRepo "<mytestprojectcode_repo_url>.git"
    - &localRepo "http://localhost/local/default.git"
strains:
  - name: local
     url: http://localhost:3000/
     code: *localRepo
     content: *localRepo
     static: *localRepo
  - name: default
     url: https://bla.helix-demo.xyz/
     code: *defaultRepo
     content: *defaultRepo
     static: *defaultRepo

hlx publish will say:

✅  The following strains have been published and version 56 is now online:
- bla: http://localhost:3000/
- default: https://bla.helix-demo.xyz/

You may now access your site using:
$ curl http://localhost:3000/

The last line appears to always display the url of the first strain in the list.

@rofe rofe added the bug Something isn't working label May 15, 2019
@rofe
Copy link
Contributor Author

rofe commented May 15, 2019

Relates to #711

@tripodsan
Copy link
Contributor

I agree. if the local strain now contains a package property, it would be that #518 happens again.

hmm, we should not use the local repo approach anymore. rather use the --host argument when trying to for a strains selection.

@rofe
Copy link
Contributor Author

rofe commented May 16, 2019

Fwiw, the local strain does not get a package property when doing hlx deploy.

@tripodsan tripodsan added the good first issue Good for newcomers label Jun 11, 2019
@tripodsan
Copy link
Contributor

won't fix for helix 2. irrelevant for helix 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants