feat(publish): Support for custom VCL logic #893

kptdobe · 2019-05-15T14:20:26Z

PR for #812

codecov · 2019-05-15T14:20:36Z

Codecov Report

Merging #893 into master will decrease coverage by 6.17%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
- Coverage   91.75%   85.58%   -6.18%     
==========================================
  Files          43       43              
  Lines        1796     1804       +8     
==========================================
- Hits         1648     1544     -104     
- Misses        148      260     +112

Impacted Files	Coverage Δ
src/publish.js	`30% <ø> (-60%)`	⬇️
src/remotepublish.cmd.js	`84.1% <88.23%> (-15.9%)`	⬇️
src/clean.cmd.js	`20.83% <0%> (-79.17%)`	⬇️
src/up.js	`27.77% <0%> (-55.56%)`	⬇️
src/yargs-github.js	`50% <0%> (-50%)`	⬇️
src/git-utils.js	`62.65% <0%> (-37.35%)`	⬇️
src/package.cmd.js	`88.11% <0%> (-1.99%)`	⬇️
src/hack.js	`100% <0%> (ø)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aedbd85...5dbad80. Read the comment docs.

codecov · 2019-05-15T14:20:37Z

Codecov Report

Merging #893 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   91.75%   91.84%   +0.08%     
==========================================
  Files          43       43              
  Lines        1796     1814      +18     
==========================================
+ Hits         1648     1666      +18     
  Misses        148      148

Impacted Files	Coverage Δ
src/publish.js	`90% <ø> (ø)`	⬆️
src/remotepublish.cmd.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f1b62...41c380d. Read the comment docs.

tripodsan

add tests for passing the vlc arguments to test/testPublishCli.js

tripodsan · 2019-05-16T01:24:18Z

src/remotepublish.cmd.js

@@ -155,6 +158,30 @@ class RemotePublishCommand extends AbstractCommand {
    return this;
  }

+  withCustomVCL(value) {
+    if (value && value.length > 0) {


from an API perspective, I think this should also allow adding single VLCs and update the internal this._vcl.
otherwise, rename it to withCustomVCLs()

Since the parameter custom-vcl (list of file paths) has to be transformed into an object (name:contentoffile), I initially thought we could have the 2 methods to have the 2 ways of providing the data: either the list of files or the object directly. But you are right, this is confusing and introduce useless features. I removed the second method.

tripodsan · 2019-05-16T01:26:14Z

src/remotepublish.cmd.js

+    return this;
+  }
+
+  withVCL(value) {


no jsdoc

what's the purpose of this in contrast to withCustomVCL ? do you really need both?

needs to be an object, so name it withVCLs

tripodsan · 2019-05-16T01:26:23Z

src/remotepublish.cmd.js

@@ -155,6 +158,30 @@ class RemotePublishCommand extends AbstractCommand {
    return this;
  }

+  withCustomVCL(value) {


ah ah. I adopted the jsdoc pattern of that file :) but you are right, that's not a reason, we need to start somewhere.

tripodsan · 2019-05-16T01:28:22Z

test/testRemotePublishCmd.customvcl.js

+    await remote.run();
+
+    assert.deepEqual(vcl, {
+      extensions: fs.readFileSync(e).toString(),


async, please

test/testRemotePublishCmd.customvcl.js

tripodsan · 2019-05-16T01:29:36Z

test/testRemotePublishCmd.customvcl.js

+
+    // eslint-disable-next-line no-underscore-dangle
+    assert.deepEqual(remote._vcl, {
+      extensions: fs.readFileSync(e).toString(),


async please

Co-Authored-By: Tobias Bocanegra <tripodsan@users.noreply.github.com>

ghost · 2019-05-16T08:24:06Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2019-05-16T08:24:09Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2019-05-16T08:48:35Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2019-05-16T08:55:48Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2019-05-16T08:59:40Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2019-05-16T09:10:44Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2019-05-16T10:01:47Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2019-05-16T12:07:34Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2019-05-16T12:16:19Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost · 2019-05-16T12:23:05Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

kptdobe · 2019-05-16T12:26:40Z

Yeah... managed to bring the code coverage back to positive!

ghost · 2019-05-20T08:42:32Z

There were the following issues with this Pull Request

Commit: d0f7367
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

# [3.1.0](v3.0.0...v3.1.0) (2019-05-20) ### Bug Fixes * **package:** update snyk to version 1.165.1 ([79e12f7](79e12f7)) ### Features * **publish:** Support for custom VCL logic ([#893](#893)) ([d773f2a](d773f2a))

adobe-bot · 2019-05-20T08:57:46Z

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

kptdobe added 2 commits May 15, 2019 11:40

feat(publish): support custom vcl

a32aaef

feat(publish): Add tests for custom-vcl

5dbad80

kptdobe added 2 commits May 15, 2019 16:36

Merge branch 'master' into support-custom-vcl

aa7407e

feat(publish): fix the tests and make code a stronger

4af608d

tripodsan requested changes May 16, 2019

View reviewed changes

Update test/testRemotePublishCmd.customvcl.js

d0f7367

Co-Authored-By: Tobias Bocanegra <tripodsan@users.noreply.github.com>

fix(publish): integrate feedback

8500b1e

fix(publish): fix broken test

3396e98

Merge branch 'master' into support-custom-vcl

c612403

fix(publish): fix the tests

aa400b3

fix(publish): Tentative to increase codecov

01670dc

fix(publish): Add one more test

9cae098

fix(publish): test more code

5a1fd86

fix(publish): assert throws error

fd4d23b

kptdobe requested a review from tripodsan May 16, 2019 12:26

kptdobe mentioned this pull request May 16, 2019

Use vcl extension points adobe/helix-pages#12

Merged

tripodsan approved these changes May 20, 2019

View reviewed changes

fix(publish): correct the resolution path

41c380d

kptdobe merged commit d773f2a into master May 20, 2019

kptdobe deleted the support-custom-vcl branch May 20, 2019 08:53

adobe-bot added the released label May 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(publish): Support for custom VCL logic #893

feat(publish): Support for custom VCL logic #893

kptdobe commented May 15, 2019

codecov bot commented May 15, 2019

codecov bot commented May 15, 2019 •

edited

Loading

tripodsan left a comment

tripodsan May 16, 2019

kptdobe May 16, 2019

tripodsan May 16, 2019

tripodsan May 16, 2019

kptdobe May 16, 2019

tripodsan May 16, 2019

tripodsan May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

kptdobe commented May 16, 2019

ghost commented May 20, 2019

adobe-bot commented May 20, 2019

feat(publish): Support for custom VCL logic #893

feat(publish): Support for custom VCL logic #893

Conversation

kptdobe commented May 15, 2019

codecov bot commented May 15, 2019

Codecov Report

codecov bot commented May 15, 2019 • edited Loading

Codecov Report

tripodsan left a comment

Choose a reason for hiding this comment

tripodsan May 16, 2019

Choose a reason for hiding this comment

kptdobe May 16, 2019

Choose a reason for hiding this comment

tripodsan May 16, 2019

Choose a reason for hiding this comment

tripodsan May 16, 2019

Choose a reason for hiding this comment

kptdobe May 16, 2019

Choose a reason for hiding this comment

tripodsan May 16, 2019

Choose a reason for hiding this comment

tripodsan May 16, 2019

Choose a reason for hiding this comment

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

ghost commented May 16, 2019

kptdobe commented May 16, 2019

ghost commented May 20, 2019

adobe-bot commented May 20, 2019

codecov bot commented May 15, 2019 •

edited

Loading