Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update petridish@2.5.0 to helix-simulator@2.6.1 #314

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

stefan-guggisberg
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

adobe/git-server#13
adobe/git-server#38
adobe/git-server#39
adobe/git-server#40

Thanks for contributing!

@tripodsan tripodsan merged commit 9bc1ca4 into adobe:master Nov 12, 2018
tripodsan added a commit that referenced this pull request Nov 12, 2018
@tripodsan
Copy link
Contributor

the new git server doesn't work on circleci:
https://circleci.com/gh/adobe/helix-cli/1485

tripodsan added a commit that referenced this pull request Nov 12, 2018
tripodsan added a commit that referenced this pull request Nov 12, 2018
* Reverts: "update petridish@2.5.0 to helix-simulator@2.6.1 (#314)"
* explicitly downgrade git-server (see adobe/helix-simulator#92)
@stefan-guggisberg
Copy link
Contributor Author

the new git server doesn't work on circleci:
https://circleci.com/gh/adobe/helix-cli/1485

@tripodsan strange, git-server built and completed tests successfully on circleci:

https://circleci.com/gh/adobe/git-server/234

@stefan-guggisberg
Copy link
Contributor Author

the reason why it works on git-server and helix-simulator circleci builds but fails on helix-cli is the different docker image versions being used. helix-cli uses circleci/node:8-stretch (debian 9) whereas the others are using circleci/node:8 (debian 8).

i've found similar problems with openssl on debian 9 vs debian 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants