Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update petridish@2.5.0 to helix-simulator@2.6.1 #317 #318

Merged
merged 3 commits into from
Nov 13, 2018

Conversation

tripodsan
Copy link
Contributor

see #317

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #318 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   77.12%   77.12%           
=======================================
  Files          28       28           
  Lines        1460     1460           
  Branches      220      220           
=======================================
  Hits         1126     1126           
  Misses        334      334
Impacted Files Coverage Δ
src/up.cmd.js 69.81% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa89ab3...c4303b8. Read the comment docs.

@stefan-guggisberg
Copy link
Contributor

@tripodsan i've changed the circleci image from circleci/node:8-stretch to circleci/node:8. now the circleci build succeeds.

@tripodsan
Copy link
Contributor Author

thanks @stefan-guggisberg. I think I changed it one to get a more modern npm, but we don't need it anymore.

@tripodsan tripodsan merged commit a6c386b into master Nov 13, 2018
@tripodsan tripodsan deleted the update-helix-simulator branch November 13, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants