feat(error): add response.errorStack for additional information. (#375)

fixes #374
adobe · Jun 12, 2019 · e7a264b · e7a264b
1 parent eac3fce
commit e7a264b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/src/utils/openwhisk.js b/src/utils/openwhisk.js
@@ -92,6 +92,9 @@ async function createActionResponse(context) {
   if (error) {
     // don't set the 'error' property, otherwise openwhisk treats this as application error
     ret.errorMessage = String(error);
+    if (error.stack) {
+      ret.errorStack = String(error.stack);
+    }
   }
   return ret;
 }

diff --git a/test/testHTML.js b/test/testHTML.js
@@ -645,6 +645,8 @@ ${context.content.document.body.innerHTML}`,
       path: 'not-existent.md',
     });
 
+    assert.ok(out.errorStack.startsWith('StatusCodeError: 404'));
+    delete out.errorStack;
     assert.deepEqual(out, {
       body: '',
       errorMessage: 'StatusCodeError: 404 - "404: Not Found\\n"',

diff --git a/test/testOpenwhisk.js b/test/testOpenwhisk.js
@@ -80,6 +80,8 @@ describe('Testing OpenWhisk adapter', () => {
       error: new Error('boom!'),
     };
     const out = await createActionResponse(inp);
+    assert.ok(out.errorStack.startsWith('Error: boom!'));
+    delete out.errorStack;
     assert.deepEqual(out, {
       body: {},
       errorMessage: 'Error: boom!',
@@ -103,6 +105,8 @@ describe('Testing OpenWhisk adapter', () => {
       error: new Error('Forbidden'),
     };
     const out = await createActionResponse(inp);
+    assert.ok(out.errorStack.startsWith('Error: Forbidden'));
+    delete out.errorStack;
     assert.deepEqual(out, {
       body: 'Forbidden',
       errorMessage: 'Error: Forbidden',
@@ -121,6 +125,8 @@ describe('Testing OpenWhisk adapter', () => {
       foo.bar = 'boom!';
     }, pipe, {});
 
+    assert.ok(out.errorStack.startsWith('ReferenceError: foo is not defined'));
+    delete out.errorStack;
     assert.deepEqual(out, {
       body: {},
       errorMessage: 'ReferenceError: foo is not defined',