This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
fix: respect image hashes with dimensions #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1134 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 60
Lines 1623 1623
=========================================
Hits 1623 1623
Continue to review full report at Codecov.
|
rofe
approved these changes
Aug 24, 2021
adobe-bot
pushed a commit
that referenced
this pull request
Aug 24, 2021
## [14.0.34](v14.0.33...v14.0.34) (2021-08-24) ### Bug Fixes * respect image hashes with dimensions ([#1134](#1134)) ([9390c93](9390c93))
|
🎉 This PR is included in version 14.0.34 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the inclusion of the image dimensions, we should remove them when rewriting the image urls to the media-urls, until the helix-pages picture handling is adjusted accordingly.