This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
fix(html pipe): Generate proper identifiers for complex headings #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly support complex headers that include child elements (strong, em, code, etc.) when automatically generating the heading identifiers fix #26
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 40 40
Lines 982 979 -3
Branches 202 202
=====================================
- Hits 982 979 -3
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly support complex headers that include child elements (strong, em, code, etc.) when
automatically generating the heading identifiers
This is a follow-up to #240 as @trieloff identified a remaining bug in the implementation as complex headings were not supported.
fix #26