Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

SVG icon sprites #523

Open
rofe opened this issue Nov 8, 2019 · 1 comment
Open

SVG icon sprites #523

rofe opened this issue Nov 8, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@rofe
Copy link
Contributor

rofe commented Nov 8, 2019 •
edited
Loading

As originally mentioned by @davidnuescheler in #500, this enhancement request is for adding support for SVG sprites, so all icons of a site could be stored in a single SVG file and referenced by ID, e.g.:

Sprite URL: /icons.svg (configurable or by convention)

<svg class="icon icon-twitter">
    <use xlink:href="/icons.svg#twitter"></use>
</svg>
@rofe rofe added the enhancement New feature or request label Nov 8, 2019
@rofe rofe mentioned this issue Nov 8, 2019
Closed
rofe added a commit that referenced this issue Nov 12, 2019
@rofe
feat(icons): make class name and URL configurable (#523)
477bf90
@rofe rofe mentioned this issue Nov 12, 2019
Closed
@rofe rofe assigned rofe and unassigned rofe Nov 12, 2019
@rofe
Copy link
Contributor Author

rofe commented Sep 23, 2021

@davidnuescheler should we move this to helix-pipeline-service or close won't fix?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rofe @MarquiseRosier