Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Support Custom VCL #79

Closed
trieloff opened this issue May 10, 2019 · 3 comments
Closed

Support Custom VCL #79

trieloff opened this issue May 10, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request released

Comments

@trieloff
Copy link
Contributor

See adobe/helix-cli#812 (comment)

The payload should accept a new parameter vcl, which is an object. For each property of that object that has a corresponding file in /layouts/fastly/${name}.vcl, create a VCL file using the Fastly API, which is overriding the default from /layouts/fastly/*

@trieloff trieloff added the enhancement New feature or request label May 10, 2019
@kptdobe kptdobe self-assigned this May 14, 2019
@kptdobe
Copy link
Contributor

kptdobe commented May 14, 2019

To cover adobe/helix-cli#812, we only need to be able to override the newly introduced extensions.vcl (see #85). We do not have a usecase yet for all the other vcl files override, I would not offer the capability and wait for customer asking for it (trivial to implement but really costly to maintain)

@kptdobe
Copy link
Contributor

kptdobe commented May 16, 2019

Custom VCL support has been introduced via the vcl https://github.com/adobe/helix-publish/blob/master/layouts/fastly/extensions.vcl.
The publish service accepts now a vcl parameter and for now only support "override" is this extensions.vcl that can be overriden by providing the value: { ... "vcl": { "extensions": "your_extensions_vcl_override"}...}

To use in a project, check adobe/helix-cli#812.

Please also note that the mechanism might be updated soon. See #94.

@kptdobe kptdobe closed this as completed May 16, 2019
@adobe-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

3 participants