Conditions integrate #256
Merged
Conditions integrate #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use match(req) instead of toFunction()(req) - use null Condition instead of isEmpty() function
…-shared into conditions_integrate
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 22 22
Lines 1188 1188
Branches 284 284
=======================================
Hits 1182 1182
Misses 6 6 Continue to review full report at Codecov.
|
|
@trieloff , I added another commit to the branch to add the breaking change, but now the smoke test fails, although it doesn't seem to be related to |
|
🎉 This PR is included in version 5.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
adobe-bot
pushed a commit
that referenced
this pull request
Feb 28, 2020
# [6.0.0](v5.3.1...v6.0.0) (2020-02-28) ### Documentation * **changelog:** mark 5.3.1 as a breaking change ([b556e6e](b556e6e)), closes [#256](#256) [#253](#253) [#254](#254) ### BREAKING CHANGES * **changelog:** The 5.3.1 release introduces breaking changes for conditions handling. This commit formally acknowledges that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: rename toFunction() to match()