Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yaml): modified strain doesn't preserve version-lock on save #395

Merged
merged 2 commits into from
Dec 4, 2020
Merged

fix(yaml): modified strain doesn't preserve version-lock on save #395

merged 2 commits into from
Dec 4, 2020

Conversation

tripodsan
Copy link
Contributor

fixes #394

@codecov
Copy link

codecov bot commented Dec 3, 2020 •
edited
Loading

Codecov Report

Merging #395 (cf904f6) into main (ad5f903) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          26       26           
  Lines        1234     1234           
  Branches      281      282    +1     
=======================================
  Hits         1229     1229           
  Misses          5        5
Impacted Files Coverage Δ
src/Strain.js 99.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfe0f6...cf904f6. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 3, 2020

This PR will trigger a patch release when merged.

@tripodsan tripodsan merged commit 70569e2 into main Dec 4, 2020
@tripodsan tripodsan deleted the fix-version-lock-serialization branch December 4, 2020 01:02
adobe-bot pushed a commit that referenced this pull request Dec 4, 2020
@semantic-release-bot
chore(release): 7.16.4 [skip ci]
987e801 
## [7.16.4](v7.16.3...v7.16.4) (2020-12-04)

### Bug Fixes

* **yaml:** modified strain doesn't preserve version-lock on save ([#395](#395)) ([70569e2](70569e2)), closes [#394](#394)
@adobe-bot
Copy link

🎉 This PR is included in version 7.16.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trieloff trieloff trieloff approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HelixConfig.toYaml() doesn't preserve version lock
3 participants
@tripodsan @adobe-bot @trieloff