fix: make some properties required #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 27 27
Lines 1280 1280
Branches 290 290
=======================================
Hits 1262 1262
Misses 18 18 Continue to review full report at Codecov.
|
trieloff
approved these changes
Apr 15, 2021
adobe-bot
pushed a commit
that referenced
this pull request
Apr 15, 2021
## [7.25.1](v7.25.0...v7.25.1) (2021-04-15) ### Bug Fixes * make some properties required ([#479](#479)) ([cad4af3](cad4af3))
|
🎉 This PR is included in version 7.25.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while adding a new index in a project and forgetting one of those. These should all be required.
Note, that
target- when omitted - defaults to an Algolia index. Might be worth changing this behaviour, e.g. maketargetrequired as well.