fix: safari errors #784
Merged
fix: safari errors #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Authorization header is not sent for page subresources (#791) * chore(deps): update dependency jsdoc-to-markdown to v9 (#793) * feat: let browser decide which images to render (#794) * fix: various security fixes (#792) --------- Co-authored-by: Andrei Tuicu <andrei.tuicu@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alexandre Capt <acapt@adobe.com>
## [6.47.1](v6.47.0...v6.47.1) (2024-09-04) ### Bug Fixes * **ci:** upgrade to node 20.8.1 ([c5a0a26](c5a0a26))
## [6.47.2](v6.47.1...v6.47.2) (2024-09-04) ### Bug Fixes * **rum:** instrument options page ([#796](#796)) ([b5626cc](b5626cc))
# [6.48.0](v6.47.2...v6.48.0) (2024-09-09) ### Features * **options:** do not use giturl anymore ([#798](#798)) ([08a4e50](08a4e50))
Co-authored-by: walf <walf@adobe.com>
Co-authored-by: walf <walf@adobe.com>
## [6.49.1](v6.49.0...v6.49.1) (2024-09-17) ### Bug Fixes * latest translations ([#809](#809)) ([ded27e9](ded27e9))
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix: Authorization header is not sent for page subresources (#791) * chore(deps): update dependency jsdoc-to-markdown to v9 (#793) * feat: let browser decide which images to render (#794) * fix: various security fixes (#792) --------- Co-authored-by: Andrei Tuicu <andrei.tuicu@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alexandre Capt <acapt@adobe.com>
rofe
commented
Oct 1, 2024
| @@ -68,7 +68,7 @@ | |||
| "puppeteer-to-istanbul": "1.4.0", | |||
| "request": "2.88.2", | |||
| "semantic-release": "24.1.2", | |||
| "semantic-release-discord-bot": "^1.1.0", | |||
| "semantic-release-discord-bot": "1.1.0", | |||
There was a problem hiding this comment.
Fixed dependencies only
rofe
commented
Oct 1, 2024
| @@ -18,7 +18,8 @@ | |||
| log, | |||
| getState, | |||
| removeCacheParam, | |||
| } = await import('./utils.js'); | |||
| url, | |||
| } = await import(chrome.runtime.getURL('utils.js')); | |||
There was a problem hiding this comment.
Safari now complains about relative dynamic imports
rofe
commented
Oct 1, 2024
| @@ -2496,7 +2496,7 @@ import sampleRUM from './rum.js'; | |||
| sk.showWait(); | |||
| const loginUrl = getAdminUrl(sk.config, 'login'); | |||
| let extensionId = window.chrome?.runtime?.id; | |||
| if (!extensionId || window.navigator.vendor.includes('Apple')) { // exclude safari | |||
There was a problem hiding this comment.
Switch to header-based auth in Safari
rofe
commented
Oct 1, 2024
| @@ -64,7 +64,7 @@ export default async function injectSidekick(config, display) { | |||
| } = curatedConfig; | |||
|
|
|||
| // todo: improve config change handling. currently we only update the authToken | |||
| chrome.storage.session.onChanged.addListener((changes) => { | |||
There was a problem hiding this comment.
Safari does not know this
rofe
commented
Oct 1, 2024
Comment on lines
+556
to
+557
| header: 'authorization', | ||
| value: `token ${authToken}`, |
There was a problem hiding this comment.
Switching to authorization header because Safari only allows to modify a fixed list of well-known headers.
tripodsan
reviewed
Oct 2, 2024
tripodsan
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #831
Fix #830