inline elements lose spaces

[kptdobe]

https://theblog-adobe.hlx.page/en/drafts/migrated/2020/04/14/using-creativity-to-honorheroes-doing-extraordinary-things-during-covid-19.html

Many spaces are missing. Source DOM contains spans where space is trimmed.

[kptdobe]

The issue is coming from: rehypejs/rehype-minify#19

[davidnuescheler]

i think this has improved very much, i still found an occurence here:

https://theblog.adobe.com/financial-services-require-artists-touch/

vs.

https://blog.adobe.com/en/drafts/migrated/2020/06/01/financial-services-require-artists-touch.html

see at the very bottom

[kptdobe]

First, the rehype-minify issue has been fixed, I still need to integrate properly the fix.

And yes, what you describe is the _emphasis with a trailing space _ where space is trimmed on rendering.

I think now this is a bug in our pipeline: Github and VSCode markdown preview can deal with it properly!

[trieloff]

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

• v1.12.0
• GitHub release

Your semantic-release bot 📦🚀

[kptdobe]

No, wrong assumption: it works because there is another emphasis to close the sentence:

_emphasis _test_._ in that case GitHub and VSCode parser is smarter than ours.

emphasis test.

vs

_emphasis _test.

[kptdobe]

Now importer moves the leading and trailing spaces outside some of the inline elements. This full fixes this issue.

[trieloff]

🎉 This issue has been resolved in version 1.12.1 🎉

The release is available on:

• v1.12.1
• GitHub release

Your semantic-release bot 📦🚀

[davidnuescheler]

i am not sure if this all should be fixed, but i am still seeing a similar issue...

https://theblog.adobe.com/digital-workflows-help-the-usa-today-creative-team-report-the-news-from-home

vs.

https://blog.adobe.com/en/drafts/migrated/2020/05/28/digital-workflows-help-the-usa-today-creative-team-report-the-news-from-home.html#gs.8bn6yi

look for "team projects"

[kptdobe]

Well... I am just overriding the whole content. You should start testing in.. 2h :)
I check this one.

[kptdobe]

End even with the current version, I do not see an issue with "team projects". Cache ?

[kptdobe]

Only thing I see wrong here is: Adoption across teams** **
But here, they do not help me, the DOM is <h2>Adoption across teams<b><br></b></h2>....

[davidnuescheler]

i just stumbled over another one...

https://theblog.adobe.com/99u-conference-2020-goes-virtual

vs.

https://theblog--adobe.hlx.page/en/drafts/migrated/2020/05/28/99u-conference-2020-goes-virtual.html#gs.7s90t9

search for the ul starting with '99U Live on Behance'

[kptdobe]

Last one fixed with #55.

[trieloff]

🎉 This issue has been resolved in version 1.14.0 🎉

The release is available on:

• v1.14.0
• GitHub release

Your semantic-release bot 📦🚀