Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get categories of top level (parentId === 0) #15

Open
filipchuk opened this issue Apr 10, 2020 · 0 comments
Open

Can't get categories of top level (parentId === 0) #15

filipchuk opened this issue Apr 10, 2020 · 0 comments

Comments

@filipchuk
Copy link

Issue report

To get tree (child categories) need to use method \AdobeStock\Api\Client\SearchCategory::getCategoryTree
This method has next lines:
if ($request->getCategoryId() == null) { throw StockApiException::withMessage('Category Id cannot be null'); }

But categories of top level have parentId == 0. And exception thrown in this case

It could be fixed if use strict compare with null
if ($request->getCategoryId() === null) { throw StockApiException::withMessage('Category Id cannot be null'); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant