Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP thumbnail size ignored due to incorrect mapping #5

Open
benhath opened this issue Mar 7, 2018 · 0 comments
Open

PHP thumbnail size ignored due to incorrect mapping #5

benhath opened this issue Mar 7, 2018 · 0 comments

Comments

@benhath
Copy link

benhath commented Mar 7, 2018

The thumbnail size parameter is incorrect...

'[filters]' should be removed from the thumbnail_size line in order to return the correct sized thumbnail.

https://github.com/adobe/stock-api-sdk/blob/master/stock-api-libphp/src/Models/SearchParameters.php

'filters_thumbnail_size' => '[filters][thumbnail_size]',

Also, the size definitions appear different to that of the documentation.

https://github.com/adobe/stock-api-sdk/blob/master/stock-api-libphp/src/Core/Constants.php
Original...
$_searchParamsThumbSizes = [ 'MEDIUM' => 110, 'BIG' => 160, 'XL' => 500, 'XXL' => 1000, ];

As per docs...
$_searchParamsThumbSizes = [ 'SMALL' => 110, 'MEDIUM' => 160, 'LARGE' => 240, 'XL' => 500, 'XXL' => 1000, ];

The watermark appears on each image at 240px, how can we remove the thumbnail watermark as per the documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant