fix(MWPW-145210): Removes role=tab from carousel elements #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmiqueo
requested review from
sanrai,
arshadparwaiz,
jedjedjedM,
sheridansunier,
gmirijan and
shkhan91
cmiqueo
temporarily deployed
to
github-pages
GitHub Actions
Inactive
sanrai
approved these changes
Sep 13, 2024
gmirijan
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes the role="tab" attribute from the carousel elements
Adds a focus-ring to the selected card in the carousel.
Removes "empty" selection when tabbing between cards
Resolves:
https://jira.corp.adobe.com/browse/MWPW-145210