Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mwpw-164262): makes headings and text more accessible #217

Merged
merged 16 commits into from
Jan 21, 2025
Merged

Conversation

cmiqueo
Copy link
Collaborator

@cmiqueo cmiqueo commented Jan 13, 2025

Description:
As explained in the WCAG 2.1 website the content should be legible with the following text settings:

  • Line height (line spacing) to at least 1.5 times the font size;
  • Spacing following paragraphs to at least 2 times the font size;
  • Letter spacing (tracking) to at least 0.12 times the font size;
  • Word spacing to at least 0.16 times the font size.

This PR ensures that if the user locally applies these settings, the card's titles and copy content will still be fully displayed.
The title and content section will expand in height accordingly to accommodate the new text style.

Resolves:
https://jira.corp.adobe.com/browse/MWPW-164262

Copy link

Core Web Vitals Metrics

Metric Value
LCP N/A s
FID N/A ms
CLS N/A

Recorded at: 2025-01-13T18:39:39.662Z
PR: #217

Copy link

Core Web Vitals Metrics

Metric Value
LCP N/A s
FID N/A ms
CLS N/A

Recorded at: 2025-01-13T20:54:40.790Z
PR: #217

Copy link

Core Web Vitals Metrics

Metric Value
LCP N/A s
FID N/A ms
CLS N/A

Recorded at: 2025-01-13T20:59:12.919Z
PR: #217

Copy link

Core Web Vitals Metrics

Metric Value
LCP 10711.30 s
FID 0.80 ms
CLS N/A

Recorded at: 2025-01-13T21:03:20.709Z
PR: #217

Copy link

Core Web Vitals Metrics

Metric Value
LCP 9598.00 s
FID 0.90 ms
CLS N/A

Recorded at: 2025-01-13T21:31:32.496Z
PR: #217

Copy link

Core Web Vitals Metrics

Metric Value
LCP 10530.70 s
FID 0.70 ms
CLS N/A

Recorded at: 2025-01-13T21:33:11.585Z
PR: #217

Copy link

Core Web Vitals Metrics

Metric Value
LCP 10655.00 s
FID 0.80 ms
CLS N/A

Recorded at: 2025-01-14T18:55:14.462Z
PR: #217

Copy link

Core Web Vitals Metrics

Metric Value
LCP 13091.50 s
FID 0.80 ms
CLS N/A

Recorded at: 2025-01-15T23:22:40.222Z
PR: #217

@cmiqueo cmiqueo changed the title fix(MWPW-164262): makes headings and text more accessible fix(mwpw-164262): makes headings and text more accessible Jan 16, 2025
Copy link

Core Web Vitals Metrics

Metric Value
LCP 12855.40 s
FID 0.70 ms
CLS N/A

Recorded at: 2025-01-16T02:13:21.080Z
PR: #217

.github/workflows/pull-request.yaml Outdated Show resolved Hide resolved
@sanrai
Copy link
Collaborator

sanrai commented Jan 21, 2025

Will these changes apply and work in Firefox/IE/Edge or is that out of scope for this request?

Copy link

Core Web Vitals Metrics

Metric Value
LCP 12839.50 s
FID 0.90 ms
CLS N/A

Recorded at: 2025-01-21T23:30:17.131Z
PR: #217

@cmiqueo cmiqueo merged commit ba2f391 into main Jan 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants