Sorting of merch-cards

[yesil]

In a previous discussion, we agreed to allow-list all possible product names, so that authors can add in the block config as a last optional token merch-card's technical name for supporting deeplinking.
With MWPW-142130, a new use cased raised that cannot be addressed with the above.
For example, there are multiple special offers merch cards with the same name individual.

In an effort to address both use cases and simplify the design, I propose the following changes:

1. Remove the allow list.
2. Move the card name to tagging section of merch-card.
3. The first heading (h3-h6) found would provide the card's technical name that can be used for both deeplinking or sort order in merch-cards block.

[Axelcureno]

I like this approach. I'm wondering how (or if) the extra row for tagging could impact existing cards, perhaps we can catch the tag at the beginning of init() if merch-cards exists inside the section. Since we play a lot with row positioning, we should think of a backward compatible solution that doesn't impact the big number of variants that already exist. Sorry for getting into the technical aspect, I know that is not the purpose of the discussion but just wanted to give my 2 cents from a technical perspective.

[yesil]

Good news is that the extra row is already supported, and used for catalog cards.
For the technical implementation, it is in line with your suggestion, see https://github.com/adobecom/milo/blob/main/libs/blocks/merch-card/merch-card.js#L343-L347.

[honstar]

I think moving towards a tag-based approach instead of using a css-class for product attribution makes a lot of sense.

What about migration of existing cards? Do we know how many cards would be affected? cc: @elevendozen @geri-w

[yesil]

Sorry @geri-w I meant as follows:

there aftereffects is authored in the same cell as filters, but just on top of them.
And yes for the headings: h3, h4, h5, h6.

[geri-w]

I see @yesil thanks for the clarification. I've updated my draft example file with aftereffects in the same cell as the filters

https://adobe.sharepoint.com/:w:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7B1A07D86E-E1EC-44F4-BBB9-544022C23115%7D&file=default.docx&action=default&mobileredirect=true

When we have confirmation that this is the approach we will use, let us know and we will create a new DOTCOM ticket to update all the Catalog cards to move the product tag out of the block title down into the filter row.

cc: @elevendozen

[yesil]

When we have confirmation that this is the approach we will use

I guess you need this change to be merged into Milo main in order to start making the DOTCOM changes?
Let me confirm this hopefully during this week.

[geri-w]

@yesil it looks like the PR was merged to Main here: https://jira.corp.adobe.com/browse/MWPW-142130

@elevendozen it looks like you are testing the new tagging on SO cards: https://jira.corp.adobe.com/browse/DOTCOM-109752

Checking if I can stat with re-tagging the Catalog cards, as noted here: https://github.com/orgs/adobecom/discussions/1847#discussioncomment-8445062 or should I wait until you've validated with Promos here: https://jira.corp.adobe.com/browse/DOTCOM-117706

[fwelterlin]

Hello all... ah yes, moving the card "name" from the block attribute to the bottom, for Catalog cards, is still pending and needs to be done. We can start ASAP. Can we please use H6 header? This is what i am using on the SO cards. I know its arbitrary but being consistent with things is always best...
I have completed this task for US special offers cards (they are published and working fine). I also sent Ravneet a ticket to get started updating the ROW special offers cards (this is simply to get ahead of things) so that when we do the switch, there will be less work (at least at the card level). Here it is -> https://jira.corp.adobe.com/browse/DOTCOM-117706