Overriding Default Milo Styling?

[Ben-Zahler]

hi all,
for some content, the default milo styling of a block does not match what we need for our content.
In some examples, this seems to be basically a bug ( I posted before on this text block in 2-up: https://main--dme-partners--adobecom.hlx.page/channelpartners/drafts/ben/demo-text-block-cta-in-2up).

For other blocks, it's more a special requirement, such as this table, where the first column has much more content than the other columns and it would make a lot of sense to have a wider first column.
https://main--dme-partners--adobecom.hlx.page/channelpartners/home/membership/

Since catching all these use cases is nearly impossible for Milo, is it acceptable/recommended for consumers to override Milo CSS based on project specific styles?

[mokimo]

It's a no-go. You can clone the block and make your own custom block out of it, if you need to, with the tradeoff that you lose all future support of that block. This is still safer than overwriting milo styles, reason being refactoring, changes to blocks, etc.
Even having query selectors on milo blocks is very dangerous and quickly leads to bugs when the blocks changes and makes it an absolute maintenance horror from a milo core block perspective

From a more strategic perspective, milo blocks are all consonant approved - this ensures we have a consistent branding and pattern across all acom surfaces. Milo still allows you to write custom blocks, however you should always question on why you want or need that and have your specific site being different compared to the rest of adobe.com.

[Ben-Zahler]

that's what I thought :-/
Copying the block is a huge tradeoff and we inherit a lot of code that we do not want to maintain. it's a no-go for me just to get a table styled to specific content where obviously the default is not ideal.

So where can I raise a requirement to have the first column in the table wider? I think it obviously makes sense on https://main--dme-partners--adobecom.hlx.page/channelpartners/home/membership/

[mokimo]

Yeah, it's a bit tedious I agree - that's the issue with having centralized logic, when things don't fit it's usually more tedious to get changes rolled out that affect everyone. For those design requests, that would have to go through consonant and then be available for everyone.

[vhargrave]

@Ben-Zahler as Okan is saying, I usually ask consonant in the #consonant_general channel. But in view it's easier if you get your PdM to send the request with the details.

[JasonHowellSlavin]

To add to this a bit as a cautionary tale. Bacom has some override styles in our styles.css https://github.com/adobecom/bacom/blob/stage/styles/styles.css#L65 and in some cases updates to blocks have broken those styles, but on the other hand we also cannot remove them without a lot of authoring effort and attempts to adjust them in milo to fit both use cases have not gone well.

Just wanted to add a use case to share how some Bacom overrides became a pain.