Text Blocks Implementation - Legal Copy and Link Farm

[drashti1712]

I am creating two new block variants of the Text Block component in milo. In order to implement this, I have added classes .legal-copy and .link-farm corresponding to each variant.

For Legal copy block, I have simply added the font, spacing and line height styles (as provided in the figma designs) to the grouped class selectors. For the link farms, I have used the concept of CSS grids on the block class (.link-farm) to give the block a column like structure. For spacing, font style, line height, link style and hover behavior, I have used the applicable CSS styles on the grouped class (example: .link-farm .text-block) and tag selectors (example: h2, h3, p).

What do you think about this approach for the implementation?

[auniverseaway]

It's hard to say without links to the proposal or links to the design you are trying to accomplish. Where's the JIRA ticket of the original ask? What do the tables look like? How do they change? What do you think are the pros and cons of this approach?

[salonijain3]

@auniverseaway
JIRA : https://jira.corp.adobe.com/browse/MWPW-129911
Tables and screenshot are in the JIRA.
URL with the current approach looks like : https://main--cc--adobecom.hlx.page/drafts/mathuria/suhani/legalcopyimplementation?milolibs=TextBlockImpl--milo--drashti1712

This is a CSS only approach.

cc: @dstrong23

[salonijain3]

@vhargrave @chrischrischris @meganthecoder @JasonHowellSlavin can you also look at this?

[JasonHowellSlavin]

Hi @salonijain3,

A CSS only approach seems to be the right approach to me. You don't modify how the text block itself decorates or inits, and your authors can get the styles they need through a well known authoring pattern.

These kinds of specific consumer level solutions have been made to milo blocks before, and are typically documented in the kitchen sink portion of the library docs (see: `Documents -> milo -> docs -> library -> kitchen-sink).

I think a future item for us to look at would be how many consumer level styles we do want in these blocks, since when merged that CSS will load for every text block, but that doesn't block anything for me.

Link to the branch comparing against main here for those interested: main...drashti1712:milo:TextBlockImpl

[drashti1712]

Hi @JasonHowellSlavin @auniverseaway @salonijain3
Based on the inputs on this discussion, I will create a subtask to work on kitchen sink documentation. Also, as discussed in the Milo Engineering Show and Tell meeting, I will rename the 'Legal Copy' block to just 'Legal'.
With this, I am closing this discussion and moving forward with the next steps.
Thank you!