From 688356bad6b95ed04c0c571bd204fc686532ff0b Mon Sep 17 00:00:00 2001 From: Hayley Parra Date: Fri, 21 Jul 2023 16:41:59 -0700 Subject: [PATCH 1/4] Add run-lint workflow and purposeful error --- .github/workflows/run-lint.yaml | 27 +++++++++++++++++++++++++++ test/utils/utils.test.js | 1 + 2 files changed, 28 insertions(+) create mode 100644 .github/workflows/run-lint.yaml diff --git a/.github/workflows/run-lint.yaml b/.github/workflows/run-lint.yaml new file mode 100644 index 0000000000..d251f0e5de --- /dev/null +++ b/.github/workflows/run-lint.yaml @@ -0,0 +1,27 @@ +name: Lint +on: + pull_request: + types: [opened, synchronize, reopened] + paths: + - '**.js' + +jobs: + run-lint: + name: Running eslint + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + + - uses: actions/setup-node@v2 + with: + node-version: 18 + + # - name: Install dependencies + # run: npm ci + + - name: Run eslint on changed files + uses: tj-actions/eslint-changed-files@v20 + with: + config_path: ".eslintrc.js" + # ignore_path: "/path/to/.eslintignore" + # extra_args: "--max-warnings=0" diff --git a/test/utils/utils.test.js b/test/utils/utils.test.js index 282c114320..a9093b9bb5 100644 --- a/test/utils/utils.test.js +++ b/test/utils/utils.test.js @@ -385,3 +385,4 @@ describe('Utils', () => { }); }); }); + From 0845c721406d3b30fd509bea7d80c42ed5d0aec6 Mon Sep 17 00:00:00 2001 From: Hayley Parra Date: Fri, 21 Jul 2023 16:46:17 -0700 Subject: [PATCH 2/4] Run npm ci --- .github/workflows/run-lint.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-lint.yaml b/.github/workflows/run-lint.yaml index d251f0e5de..3aab1f8ebb 100644 --- a/.github/workflows/run-lint.yaml +++ b/.github/workflows/run-lint.yaml @@ -16,8 +16,8 @@ jobs: with: node-version: 18 - # - name: Install dependencies - # run: npm ci + - name: Install dependencies + run: npm ci - name: Run eslint on changed files uses: tj-actions/eslint-changed-files@v20 From 3e64bc4f980f617da9cf3dd213a57142625f9e21 Mon Sep 17 00:00:00 2001 From: Hayley Parra Date: Fri, 21 Jul 2023 16:51:26 -0700 Subject: [PATCH 3/4] Fix newline i left on purpose --- test/utils/utils.test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/utils/utils.test.js b/test/utils/utils.test.js index a9093b9bb5..282c114320 100644 --- a/test/utils/utils.test.js +++ b/test/utils/utils.test.js @@ -385,4 +385,3 @@ describe('Utils', () => { }); }); }); - From c3b8aa8835a170eb4c3ff55626edb46b68fc3848 Mon Sep 17 00:00:00 2001 From: Hayley Parra Date: Fri, 21 Jul 2023 16:53:34 -0700 Subject: [PATCH 4/4] Leave comment to mimic edit --- test/utils/utils.test.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/utils/utils.test.js b/test/utils/utils.test.js index 282c114320..98cb58c835 100644 --- a/test/utils/utils.test.js +++ b/test/utils/utils.test.js @@ -385,3 +385,5 @@ describe('Utils', () => { }); }); }); + +// This comment was left here intentionally