-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS SES configuration #98
Comments
I would say we should do the reverse. I mean, change the names of the environment variables I know this was the case on V5: we had variables SES_ACCESS_KEY_ID etc.. So, I'd be more in favor of keeping AWS_ACCESS_KEY_ID=
AWS_SECRET_ACCESS_KEY=
AWS_REGION= rather than SES_ACCESS_KEY_ID=
SES_SECRET_ACCESS_KEY=
SES_REGION= That way, these same variables can be used directly in the configuration of other things, like Drive for example. Without having to rename |
I'd thought about it, but I thought it might be confusing if some people were using several services with different keys. |
Hey @Julien-R44 can you merge the PR? 😃 |
Done! Thanks for fixing that |
Package version
9.2.1
Describe the bug
When configuring SES as mailer, environment variables were not properly set.
Examples:
PR #97 is solving issues. Also in docs the PR #67 is changing the example.
Reproduction repo
No response
The text was updated successfully, but these errors were encountered: