Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning: moment construction falls back to js Date #137

Closed
danielspaniel opened this issue Mar 14, 2016 · 4 comments
Closed

Comments

@danielspaniel
Copy link
Contributor

I've just stared using cp-validations, and things are looking good.
Except for this issue for using date validator ..
I reckon that the latest moment js has deprecated the use of moment(random date string)
because when I use the date validator with before: 'now' or after: '2/2/2015' or whatever .. then I get these deprecation warnings from the base date validator class.

Deprecation warning: moment construction falls back to js Date. This is discouraged and will be removed in upcoming major release. Please refer to https://github.com/moment/moment/issues/1407 for more info.
Arguments: [object Object]

Is this already known issue? Need me to try a PR? You feel like fixing?

@offirgolan
Copy link
Collaborator

A PR is always welcome! If not, I can always take a crack at it when I have some time 😄

@danielspaniel
Copy link
Contributor Author

fair enough mate. If I go for it will let you know, so we don't duplicate work.

@offirgolan
Copy link
Collaborator

👍 Thanks @danielspaniel

@offirgolan
Copy link
Collaborator

Resolved with #140 (Thanks again!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants